mantle/api: gcloud: remove FCOS specific image GuestOSFeatures#1333
Conversation
|
This is a follow-up from #1319 (comment) |
We consider the VIRTIO_SCSI_MULTIQUEUE, UEFI_COMPATIBLE, and SECURE_BOOT flags to be standard now so we can unconditionally add them to GCP images we create and get rid of the --fcos option.
dustymabe
force-pushed
the
dusty-gcp-ore-no-more-fcos-flag
branch
from
7b4045b to
6e2ab0f
Compare
dustymabe
changed the title
|
LGTM...I wrote all this stuff below then changed my mind, just attaching it for reference. I'm OK with this, though I think I'd vote instead we:
The idea here is it's slightly more convenienent for someone testing something interactively w/ore to pass |
|
Note that AFAICT this will change the defaults for the RHCOS pipeline. I'm guessing that openshift/installer#2921 only changes it at runtime when the instance is launched. |
No, as you discovered in internal chat, the openshift installer today always creates the image in GCP. That's precisely why that PR was needed (and indeed works without this one). |
|
/lgtm Thanks for the cleanup! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
We consider the VIRTIO_SCSI_MULTIQUEUE, UEFI_COMPATIBLE,
and SECURE_BOOT flags to be standard now so we can
unconditionally add them to GCP images we create and get
rid of the --fcos option.